Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): move api to this repository #157

Merged
merged 13 commits into from
Dec 3, 2024
Merged

Conversation

0x1026
Copy link
Member

@0x1026 0x1026 commented Nov 30, 2024

This pull request introduces several updates to the project, focusing on improving the CI/CD pipeline, adding support for a new API, and enhancing the overall project configuration and documentation. The most important changes include modifications to the GitHub Actions workflows, updates to the Docker configuration, and enhancements to the environment and dependency management.

Move the API to this repository, improve the Docker and CI configurations, and enhance the testing setup with coverage reporting. Simplify the Sensor model and update field names for better clarity.

CI/CD Pipeline Enhancements:

Docker Configuration:

  • Dockerfile: Added configurations for setting up and running the development and test environments with Xdebug. [1] [2]
  • api/Dockerfile: Introduced a new Dockerfile for the API service, including separate stages for dependencies, development, and production.

Environment and Dependency Management:

  • .env.example: Updated the database user and password configuration for better security.
  • api/requirements.txt and api/requirements-dev.txt: Added necessary dependencies for the FastAPI service and testing. [1] [2]

Project Configuration:

Documentation:

  • README.md: Enhanced the installation instructions to include environment variable setup and access URLs for different parts of the application.

Resources

also enhance compose and workflow to handle both images
@0x1026 0x1026 added the area/api Categorizes issue or PR as related to api. label Nov 30, 2024
@0x1026 0x1026 added this to the Sprint 3 - Prototype milestone Nov 30, 2024
@github-actions github-actions bot added area/docker Categorizes issue or PR as related to docker. kind/dependencies Categorizes issue or PR as related to dependencies. area/tests Categorizes issue or PR as related to tests. labels Dec 1, 2024
@0x1026 0x1026 force-pushed the refactor/move-api-here branch 13 times, most recently from a48d4f8 to e74f5d9 Compare December 2, 2024 01:17
@Projecte-UrbanTree Projecte-UrbanTree deleted a comment from codecov bot Dec 2, 2024
@0x1026 0x1026 force-pushed the refactor/move-api-here branch 5 times, most recently from 217b1cf to f9d7d5a Compare December 2, 2024 01:43
@Projecte-UrbanTree Projecte-UrbanTree deleted a comment from codecov bot Dec 2, 2024
@0x1026 0x1026 linked an issue Dec 2, 2024 that may be closed by this pull request
@0x1026 0x1026 added the triage/webgraphy Indicates an issue or PR contains wegraphy. label Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@0x1026 0x1026 force-pushed the main branch 2 times, most recently from f43896f to a6dd618 Compare December 2, 2024 21:12
@0x1026 0x1026 removed area/api Categorizes issue or PR as related to api. area/docker Categorizes issue or PR as related to docker. kind/dependencies Categorizes issue or PR as related to dependencies. area/tests Categorizes issue or PR as related to tests. labels Dec 2, 2024
@github-actions github-actions bot added the area/docker Categorizes issue or PR as related to docker. label Dec 2, 2024
@0x1026 0x1026 added the area/api Categorizes issue or PR as related to api. label Dec 2, 2024
@0x1026 0x1026 marked this pull request as ready for review December 3, 2024 01:58
@0x1026 0x1026 requested review from a team as code owners December 3, 2024 01:58
@0x1026 0x1026 merged commit c356441 into main Dec 3, 2024
8 checks passed
@0x1026 0x1026 deleted the refactor/move-api-here branch December 3, 2024 01:59
@0x1026 0x1026 restored the refactor/move-api-here branch December 3, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Categorizes issue or PR as related to api. area/docker Categorizes issue or PR as related to docker. triage/webgraphy Indicates an issue or PR contains wegraphy.
Projects
Status: Fet
Development

Successfully merging this pull request may close these issues.

Dockerize the microservice
1 participant